Commit e0a9ddd5 authored by RinHizakura's avatar RinHizakura Committed by Miquel Raynal
Browse files

mtd: rawnand: nandsim: Replace overflow check with kzalloc to single kcalloc 



Instead of self-checking overflow and allocating an array of specific size
by counting the total required space handy, we already have existed kernel
API which responses for all these works.

Signed-off-by: default avatarRinHizakura <s921975628@gmail.com>
Reviewed-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211225100607.118932-1-s921975628@gmail.com
parent e783362e

drivers/mtd/nand/raw/nandsim.c

+1 −8
Original line number Diff line number Diff line
@@ -979,15 +979,8 @@ static int ns_read_error(unsigned int page_no) 


static int ns_setup_wear_reporting(struct mtd_info *mtd)

{

	size_t mem;



	wear_eb_count = div_u64(mtd->size, mtd->erasesize);

	mem = wear_eb_count * sizeof(unsigned long);

	if (mem / sizeof(unsigned long) != wear_eb_count) {

		NS_ERR("Too many erase blocks for wear reporting\n");

		return -ENOMEM;

	}

	erase_block_wear = kzalloc(mem, GFP_KERNEL);

	erase_block_wear = kcalloc(wear_eb_count, sizeof(unsigned long), GFP_KERNEL);

	if (!erase_block_wear) {

		NS_ERR("Too many erase blocks for wear reporting\n");

		return -ENOMEM;