Commit e0c032d2 authored by Gal Pressman's avatar Gal Pressman Committed by Jakub Kicinski
Browse files

ice: dpll: Remove newline at the end of a netlink error message 



Netlink error messages should not have a newline at the end of the
string.

Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Acked-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250226093904.6632-6-gal@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c94fae5f

drivers/net/ethernet/intel/ice/ice_dpll.c

+7 −7
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ ice_dpll_pin_freq_set(struct ice_pf *pf, struct ice_dpll_pin *pin, 
	}

	if (ret) {

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to set pin freq:%u on pin:%u\n",

				   "err:%d %s failed to set pin freq:%u on pin:%u",

				   ret,

				   ice_aq_str(pf->hw.adminq.sq_last_status),

				   freq, pin->idx);
@@ -322,7 +322,7 @@ ice_dpll_pin_enable(struct ice_hw *hw, struct ice_dpll_pin *pin, 
	}

	if (ret)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to enable %s pin:%u\n",

				   "err:%d %s failed to enable %s pin:%u",

				   ret, ice_aq_str(hw->adminq.sq_last_status),

				   pin_type_name[pin_type], pin->idx);
@@ -367,7 +367,7 @@ ice_dpll_pin_disable(struct ice_hw *hw, struct ice_dpll_pin *pin, 
	}

	if (ret)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to disable %s pin:%u\n",

				   "err:%d %s failed to disable %s pin:%u",

				   ret, ice_aq_str(hw->adminq.sq_last_status),

				   pin_type_name[pin_type], pin->idx);
@@ -479,7 +479,7 @@ ice_dpll_pin_state_update(struct ice_pf *pf, struct ice_dpll_pin *pin, 
err:

	if (extack)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to update %s pin:%u\n",

				   "err:%d %s failed to update %s pin:%u",

				   ret,

				   ice_aq_str(pf->hw.adminq.sq_last_status),

				   pin_type_name[pin_type], pin->idx);
@@ -518,7 +518,7 @@ ice_dpll_hw_input_prio_set(struct ice_pf *pf, struct ice_dpll *dpll, 
				      (u8)prio);

	if (ret)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to set pin prio:%u on pin:%u\n",

				   "err:%d %s failed to set pin prio:%u on pin:%u",

				   ret,

				   ice_aq_str(pf->hw.adminq.sq_last_status),

				   prio, pin->idx);
@@ -1004,7 +1004,7 @@ ice_dpll_pin_phase_adjust_set(const struct dpll_pin *pin, void *pin_priv, 
	mutex_unlock(&pf->dplls.lock);

	if (ret)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to set pin phase_adjust:%d for pin:%u on dpll:%u\n",

				   "err:%d %s failed to set pin phase_adjust:%d for pin:%u on dpll:%u",

				   ret,

				   ice_aq_str(pf->hw.adminq.sq_last_status),

				   phase_adjust, p->idx, d->dpll_idx);
@@ -1362,7 +1362,7 @@ ice_dpll_rclk_state_on_pin_set(const struct dpll_pin *pin, void *pin_priv, 
					 &p->freq);

	if (ret)

		NL_SET_ERR_MSG_FMT(extack,

				   "err:%d %s failed to set pin state:%u for pin:%u on parent:%u\n",

				   "err:%d %s failed to set pin state:%u for pin:%u on parent:%u",

				   ret,

				   ice_aq_str(pf->hw.adminq.sq_last_status),

				   state, p->idx, parent->idx);