Commit e0d5ce11 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Call intel_pre_plane_updates() also for pipes getting enabled 



We used to call intel_pre_plane_updates() for any pipe going through
a modeset whether the pipe was previously enabled or not. This in
fact needed to apply all the necessary clock gating workarounds/etc.
Restore the correct behaviour.

Fixes: 39919997 ("drm/i915: Disable all planes before modesetting any pipes")
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231121054324.9988-3-ville.syrjala@linux.intel.com
parent bc53c4d5

drivers/gpu/drm/i915/display/intel_display.c

+2 −1
Original line number Diff line number Diff line
@@ -6694,10 +6694,11 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state) 
		if (!intel_crtc_needs_modeset(new_crtc_state))

			continue;



		intel_pre_plane_update(state, crtc);



		if (!old_crtc_state->hw.active)

			continue;



		intel_pre_plane_update(state, crtc);

		intel_crtc_disable_planes(state, crtc);

	}