Commit e0f3b3e5 authored by Dong Chenchen's avatar Dong Chenchen Committed by Jakub Kicinski
Browse files

selftests: Add test cases for vlan_filter modification during runtime



Add test cases for vlan_filter modification during runtime, which
may triger null-ptr-ref or memory leak of vlan0.

Signed-off-by: default avatarDong Chenchen <dongchenchen2@huawei.com>
Link: https://patch.msgid.link/20250716034504.2285203-3-dongchenchen2@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 579d4f9c
Loading
Loading
Loading
Loading
+86 −12
Original line number Diff line number Diff line
@@ -3,10 +3,22 @@

readonly NETNS="ns-$(mktemp -u XXXXXX)"

ALL_TESTS="
	test_vlan_filter_check
	test_vlan0_del_crash_01
	test_vlan0_del_crash_02
	test_vlan0_del_crash_03
	test_vid0_memleak
"

ret=0

setup() {
	ip netns add ${NETNS}
}

cleanup() {
	ip netns del $NETNS
	ip netns del $NETNS 2>/dev/null
}

trap cleanup EXIT
@@ -16,7 +28,16 @@ fail() {
	ret=1
}

ip netns add ${NETNS}
tests_run()
{
	local current_test
	for current_test in ${TESTS:-$ALL_TESTS}; do
		$current_test
	done
}

test_vlan_filter_check() {
	setup
	ip netns exec ${NETNS} ip link add bond0 type bond mode 0
	ip netns exec ${NETNS} ip link add bond_slave_1 type veth peer veth2
	ip netns exec ${NETNS} ip link set bond_slave_1 master bond0
@@ -25,5 +46,58 @@ ip netns exec ${NETNS} ip link add link bond_slave_1 name bond_slave_1.0 type vl
	ip netns exec ${NETNS} ip link add link bond0 name bond0.0 type vlan id 0
	ip netns exec ${NETNS} ip link set bond_slave_1 nomaster
	ip netns exec ${NETNS} ip link del veth2 || fail "Please check vlan HW filter function"
	cleanup
}

#enable vlan_filter feature of real_dev with vlan0 during running time
test_vlan0_del_crash_01() {
	setup
	ip netns exec ${NETNS} ip link add bond0 type bond mode 0
	ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off
	ip netns exec ${NETNS} ifconfig bond0 up
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on
	ip netns exec ${NETNS} ifconfig bond0 down
	ip netns exec ${NETNS} ifconfig bond0 up
	ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function"
	cleanup
}

#enable vlan_filter feature and add vlan0 for real_dev during running time
test_vlan0_del_crash_02() {
	setup
	ip netns exec ${NETNS} ip link add bond0 type bond mode 0
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off
	ip netns exec ${NETNS} ifconfig bond0 up
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on
	ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q
	ip netns exec ${NETNS} ifconfig bond0 down
	ip netns exec ${NETNS} ifconfig bond0 up
	ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function"
	cleanup
}

#enable vlan_filter feature of real_dev during running time
#test kernel_bug of vlan unregister
test_vlan0_del_crash_03() {
	setup
	ip netns exec ${NETNS} ip link add bond0 type bond mode 0
	ip netns exec ${NETNS} ip link add link bond0 name vlan0 type vlan id 0 protocol 802.1q
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off
	ip netns exec ${NETNS} ifconfig bond0 up
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter on
	ip netns exec ${NETNS} ifconfig bond0 down
	ip netns exec ${NETNS} ip link del vlan0 || fail "Please check vlan HW filter function"
	cleanup
}

test_vid0_memleak() {
	setup
	ip netns exec ${NETNS} ip link add bond0 up type bond mode 0
	ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off
	ip netns exec ${NETNS} ip link del dev bond0 || fail "Please check vlan HW filter function"
	cleanup
}

tests_run
exit $ret