Commit e1008628 authored by Thomas Huth's avatar Thomas Huth Committed by Sean Christopherson
Browse files

KVM: selftests: x86: sync_regs_test: Use vcpu_run() where appropriate 



In the spots where we are expecting a successful run, we should
use vcpu_run() instead of _vcpu_run() to make sure that the run
did not fail.

Suggested-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Link: https://lore.kernel.org/r/20240208204844.119326-2-thuth@redhat.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent db7d6fbc

tools/testing/selftests/kvm/x86_64/sync_regs_test.c

+5 −5
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ int main(int argc, char *argv[]) 
	/* Request and verify all valid register sets. */

	/* TODO: BUILD TIME CHECK: TEST_ASSERT(KVM_SYNC_X86_NUM_FIELDS != 3); */

	run->kvm_valid_regs = TEST_SYNC_FIELDS;

	rv = _vcpu_run(vcpu);

	vcpu_run(vcpu);

	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);



	vcpu_regs_get(vcpu, &regs);
@@ -278,7 +278,7 @@ int main(int argc, char *argv[]) 


	run->kvm_valid_regs = TEST_SYNC_FIELDS;

	run->kvm_dirty_regs = KVM_SYNC_X86_REGS | KVM_SYNC_X86_SREGS;

	rv = _vcpu_run(vcpu);

	vcpu_run(vcpu);

	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);

	TEST_ASSERT(run->s.regs.regs.rbx == 0xBAD1DEA + 1,

		    "rbx sync regs value incorrect 0x%llx.",
@@ -302,7 +302,7 @@ int main(int argc, char *argv[]) 
	run->kvm_valid_regs = TEST_SYNC_FIELDS;

	run->kvm_dirty_regs = 0;

	run->s.regs.regs.rbx = 0xDEADBEEF;

	rv = _vcpu_run(vcpu);

	vcpu_run(vcpu);

	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);

	TEST_ASSERT(run->s.regs.regs.rbx != 0xDEADBEEF,

		    "rbx sync regs value incorrect 0x%llx.",
@@ -317,7 +317,7 @@ int main(int argc, char *argv[]) 
	run->s.regs.regs.rbx = 0xAAAA;

	regs.rbx = 0xBAC0;

	vcpu_regs_set(vcpu, &regs);

	rv = _vcpu_run(vcpu);

	vcpu_run(vcpu);

	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);

	TEST_ASSERT(run->s.regs.regs.rbx == 0xAAAA,

		    "rbx sync regs value incorrect 0x%llx.",
@@ -334,7 +334,7 @@ int main(int argc, char *argv[]) 
	run->kvm_valid_regs = 0;

	run->kvm_dirty_regs = TEST_SYNC_FIELDS;

	run->s.regs.regs.rbx = 0xBBBB;

	rv = _vcpu_run(vcpu);

	vcpu_run(vcpu);

	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);

	TEST_ASSERT(run->s.regs.regs.rbx == 0xBBBB,

		    "rbx sync regs value incorrect 0x%llx.",