Commit e1048520 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Jakub Kicinski
Browse files

Octeontx2-af: Fix pci_alloc_irq_vectors() return value check 



In cgx_probe() when pci_alloc_irq_vectors() fails the error value will
be negative and that check is sufficient.

	err = pci_alloc_irq_vectors(pdev, nvec, nvec, PCI_IRQ_MSIX);
        if (err < 0 || err != nvec) {
        	...
	}

When pci_alloc_irq_vectors() fail to allocate nvec number of vectors,
-ENOSPC is returned, so it would be safe to remove the check that
compares err with nvec.

Suggested-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251015090117.1557870-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 38c31c26

drivers/net/ethernet/marvell/octeontx2/af/cgx.c

+1 −1
Original line number Diff line number Diff line
@@ -1994,7 +1994,7 @@ static int cgx_probe(struct pci_dev *pdev, const struct pci_device_id *id) 


	nvec = pci_msix_vec_count(cgx->pdev);

	err = pci_alloc_irq_vectors(pdev, nvec, nvec, PCI_IRQ_MSIX);

	if (err < 0 || err != nvec) {

	if (err < 0) {

		dev_err(dev, "Request for %d msix vectors failed, err %d\n",

			nvec, err);

		goto err_release_regions;