Commit e109dead authored Jan 04, 2024 by Steven Rostedt (Google)

eventfs: Have eventfs_iterate() stop immediately if ei->is_freed is set

If ei->is_freed is set in eventfs_iterate(), it means that the directory
that is being iterated on is in the process of being freed. Just exit the
loop immediately when that is ever detected, and separate out the return
of the entry->callback() from ei->is_freed.

Link: https://lore.kernel.org/linux-trace-kernel/20240104220048.016261289@goodmis.org



Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

parent 8186fff7

fs/tracefs/event_inode.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -788,11 +788,12 @@ static int eventfs_iterate(struct file file, struct dir_context ctx)
		name = entry->name;

		mutex_lock(&eventfs_mutex);
		/* If ei->is_freed, then the event itself may be too */
		if (!ei->is_freed)
		/* If ei->is_freed then just bail here, nothing more to do */
		if (ei->is_freed) {
		mutex_unlock(&eventfs_mutex);
		goto out;
		}
		r = entry->callback(name, &mode, &cdata, &fops);
		else
		r = -1;
		mutex_unlock(&eventfs_mutex);
		if (r <= 0)
		continue;