Commit e111cbc4 authored by Emil Tantilov's avatar Emil Tantilov Committed by Tony Nguyen
Browse files

idpf: fix memory leak in idpf_vc_core_deinit() 



Make sure to free hw->lan_regs. Reported by kmemleak during reset:

unreferenced object 0xff1b913d02a936c0 (size 96):
  comm "kworker/u258:14", pid 2174, jiffies 4294958305
  hex dump (first 32 bytes):
    00 00 00 c0 a8 ba 2d ff 00 00 00 00 00 00 00 00  ......-.........
    00 00 40 08 00 00 00 00 00 00 25 b3 a8 ba 2d ff  ..@.......%...-.
  backtrace (crc 36063c4f):
    __kmalloc_noprof+0x48f/0x890
    idpf_vc_core_init+0x6ce/0x9b0 [idpf]
    idpf_vc_event_task+0x1fb/0x350 [idpf]
    process_one_work+0x226/0x6d0
    worker_thread+0x19e/0x340
    kthread+0x10f/0x250
    ret_from_fork+0x251/0x2b0
    ret_from_fork_asm+0x1a/0x30

Fixes: 6aa53e86 ("idpf: implement get LAN MMIO memory regions")
Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: default avatarJoshua Hay <joshua.a.hay@intel.com>
Tested-by: default avatarSamuel Salin <Samuel.salin@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent f6242b35

drivers/net/ethernet/intel/idpf/idpf_virtchnl.c

+4 −0
Original line number Diff line number Diff line
@@ -3570,6 +3570,7 @@ int idpf_vc_core_init(struct idpf_adapter *adapter) 
 */

void idpf_vc_core_deinit(struct idpf_adapter *adapter)

{

	struct idpf_hw *hw = &adapter->hw;

	bool remove_in_prog;



	if (!test_bit(IDPF_VC_CORE_INIT, adapter->flags))
@@ -3593,6 +3594,9 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter) 


	idpf_vport_params_buf_rel(adapter);



	kfree(hw->lan_regs);

	hw->lan_regs = NULL;



	kfree(adapter->vports);

	adapter->vports = NULL;