Commit e11c5c13 authored by Junrui Luo's avatar Junrui Luo Committed by Takashi Iwai
Browse files

ALSA: wavefront: Clear substream pointers on close 



Clear substream pointers in close functions to avoid leaving dangling
pointers, helping to improve code safety and
prevents potential issues.

Reported-by: default avatarYuhao Jiang <danisjiang@gmail.com>
Reported-by: default avatarJunrui Luo <moonafterrain@outlook.com>
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJunrui Luo <moonafterrain@outlook.com>
Link: https://patch.msgid.link/SYBPR01MB7881DF762CAB45EE42F6D812AFC2A@SYBPR01MB7881.ausprd01.prod.outlook.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ab3bd366

sound/isa/wavefront/wavefront_midi.c

+2 −0
Original line number Diff line number Diff line
@@ -278,6 +278,7 @@ static int snd_wavefront_midi_input_close(struct snd_rawmidi_substream *substrea 
	        return -EIO;



	guard(spinlock_irqsave)(&midi->open);

	midi->substream_input[mpu] = NULL;

	midi->mode[mpu] &= ~MPU401_MODE_INPUT;



	return 0;
@@ -300,6 +301,7 @@ static int snd_wavefront_midi_output_close(struct snd_rawmidi_substream *substre 
	        return -EIO;



	guard(spinlock_irqsave)(&midi->open);

	midi->substream_output[mpu] = NULL;

	midi->mode[mpu] &= ~MPU401_MODE_OUTPUT;

	return 0;

}