Commit e1418af7 authored by Thorsten Blum's avatar Thorsten Blum Committed by Jens Axboe
Browse files

brd: replace simple_strtol with kstrtoul in ramdisk_size 



Replace simple_strtol() with the recommended kstrtoul() for parsing the
'ramdisk_size=' boot parameter. Unlike simple_strtol(), which returns a
long, kstrtoul() converts the string directly to an unsigned long and
avoids implicit casting.

Check the return value of kstrtoul() and reject invalid values. This
adds error handling while preserving behavior for existing values, and
removes use of the deprecated simple_strtol() helper. The current code
silently sets 'rd_size = 0' if parsing fails, instead of leaving the
default value (CONFIG_BLK_DEV_RAM_SIZE) unchanged.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4cef2fcd

drivers/block/brd.c

+1 −2
Original line number Diff line number Diff line
@@ -247,8 +247,7 @@ MODULE_ALIAS("rd"); 
/* Legacy boot options - nonmodular */

static int __init ramdisk_size(char *str)

{

	rd_size = simple_strtol(str, NULL, 0);

	return 1;

	return kstrtoul(str, 0, &rd_size) == 0;

}

__setup("ramdisk_size=", ramdisk_size);

#endif