Commit e1e52544 authored by Nick Kossifidis's avatar Nick Kossifidis Committed by Rob Herring
Browse files

OF: Add a warning in case chosen node is not present 

On architectures that only get their bootargs through devicetree's
chosen node (such as RISC-V), that node is mandatory. After a
discussion with Rob [1] I'm adding a warning in case chosen node
is not present, to let users know about it.

[1]: https://patchwork.ozlabs.org/patch/984224/#2016136



Signed-off-by: default avatarNick Kossifidis <mick@ics.forth.gr>
Reviewed-by: default avatarPalmer Dabbelt <palmer@sifive.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent a2237fec

drivers/of/fdt.c

+5 −1
Original line number Diff line number Diff line
@@ -1207,8 +1207,12 @@ bool __init early_init_dt_verify(void *params) 


void __init early_init_dt_scan_nodes(void)

{

	int rc = 0;



	/* Retrieve various information from the /chosen node */

	of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);

	rc = of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);

	if (!rc)

		pr_warn("No chosen node found, continuing without\n");



	/* Initialize {size,address}-cells info */

	of_scan_flat_dt(early_init_dt_scan_root, NULL);