Unverified Commit e1f2e776 authored by Ali Tariq's avatar Ali Tariq Committed by Mark Brown
Browse files

spi: cadence-qspi: Fix runtime PM imbalance in probe 



The probe function incorrectly calls pm_runtime_put_autosuspend()
twice in succession at the end of successful probe, dropping two
runtime PM references while only one was acquired earlier with
pm_runtime_get_sync(). This causes a usage count underflow:

    cadence-qspi 13010000.spi: Runtime PM usage count underflow!

Remove the first redundant pm_runtime_put_autosuspend() call to
balance the reference count.

Tested on StarFive VisionFive 2 v1.2A board.

Fixes: 30dbc1c8 ("spi: cadence-qspi: defer runtime support on socfpga if reset bit is enabled")

Signed-off-by: default avatarAli Tariq <alitariq45892@gmail.com>
Link: https://patch.msgid.link/20251130091251.12120-1-alitariq45892@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent cb5c2eb4

drivers/spi/spi-cadence-quadspi.c

+0 −1
Original line number Diff line number Diff line
@@ -2012,7 +2012,6 @@ static int cqspi_probe(struct platform_device *pdev) 
	}



	if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) {

		pm_runtime_put_autosuspend(dev);

		pm_runtime_mark_last_busy(dev);

		pm_runtime_put_autosuspend(dev);

	}