Commit e2261bb8 authored Oct 30, 2024 by Sibi Sankar Committed by Ulf Hansson Nov 12, 2024

firmware: arm_scmi: Report duplicate opps as firmware bugs



Duplicate opps reported by buggy SCP firmware currently show up
as warnings even though the only functional impact is that the
level/index remain inaccessible. Make it less scary for the end
user by using dev_info instead, along with FW_BUG tag.

Suggested-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Cc: stable@vger.kernel.org
Message-ID: <20241030125512.2884761-4-quic_sibis@quicinc.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 5d8a7662

drivers/firmware/arm_scmi/perf.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -387,7 +387,7 @@ process_response_opp(struct device dev, struct perf_dom_info dom,

		ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL);
		if (ret) {
		dev_warn(dev, "Failed to add opps_by_lvl at %d for %s - ret:%d\n",
		dev_info(dev, FW_BUG "Failed to add opps_by_lvl at %d for %s - ret:%d\n",
		opp->perf, dom->info.name, ret);
		return ret;
		}
		@@ -409,7 +409,7 @@ process_response_opp_v4(struct device dev, struct perf_dom_info dom,

		ret = xa_insert(&dom->opps_by_lvl, opp->perf, opp, GFP_KERNEL);
		if (ret) {
		dev_warn(dev, "Failed to add opps_by_lvl at %d for %s - ret:%d\n",
		dev_info(dev, FW_BUG "Failed to add opps_by_lvl at %d for %s - ret:%d\n",
		opp->perf, dom->info.name, ret);
		return ret;
		}