Commit e247a8f5 authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller
Browse files

[TIPC]: Add argument validation for shutdown() 



This patch validates that the "how" argument to shutdown()
is SHUT_RDWR, since this is the only form that TIPC supports.

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8c869655

net/tipc/socket.c

+3 −2
Original line number Diff line number Diff line
@@ -1419,7 +1419,7 @@ static int accept(struct socket *sock, struct socket *newsock, int flags) 
/**

 * shutdown - shutdown socket connection

 * @sock: socket structure

 * @how: direction to close (unused; always treated as read + write)

 * @how: direction to close (must be SHUT_RDWR)

 *

 * Terminates connection (if necessary), then purges socket's receive queue.

 *
@@ -1432,7 +1432,8 @@ static int shutdown(struct socket *sock, int how) 
	struct sk_buff *buf;

	int res;



	/* Could return -EINVAL for an invalid "how", but why bother? */

	if (how != SHUT_RDWR)

		return -EINVAL;



	if (mutex_lock_interruptible(&tsock->lock))

		return -ERESTARTSYS;