Commit e25f3040 authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski
Browse files

mlxsw: core_thermal: Simplify rollback 



During rollback, instead of calling mlxsw_thermal_module_fini() for all
the modules, only call it for modules that were successfully
initialized. This is not a bug fix since mlxsw_thermal_module_fini()
first checks that the module was initialized.

Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarVadim Pasternak <vadimp@nvidia.com>
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarWojciech Drewek <wojciech.drewek@intel.com>
Link: https://patch.msgid.link/905bebc45f6e246031f0c5c177bba8efe11e05f5.1722345311.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fb76ea1d

drivers/net/ethernet/mellanox/mlxsw/core_thermal.c

+1 −1
Original line number Diff line number Diff line
@@ -509,7 +509,7 @@ mlxsw_thermal_modules_init(struct device *dev, struct mlxsw_core *core, 
	return 0;



err_thermal_module_init:

	for (i = area->tz_module_num - 1; i >= 0; i--)

	for (i--; i >= 0; i--)

		mlxsw_thermal_module_fini(&area->tz_module_arr[i]);

	kfree(area->tz_module_arr);

	return err;