Unverified Commit e2628e67 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio Committed by Rodrigo Vivi
Browse files

drm/xe/pxp: Clean up termination status on failure 



If the PXP HW termination fails during PXP start, the normal completion
code won't be called, so the termination will remain uncomplete. To avoid
unnecessary waits, mark the termination as completed from the error path.
Note that we already do this if the termination fails when handling a
termination irq from the HW.

Fixes: f8caa801 ("drm/xe/pxp: Add PXP queue tracking and session start")
Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn Teres Alexis <alan.previn.teres.alexis@intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Reviewed-by: default avatarJulia Filipchuk <julia.filipchuk@intel.com>
Link: https://patch.msgid.link/20260324153718.3155504-7-daniele.ceraolospurio@intel.com


(cherry picked from commit 5d9e708d2a69ab1f64a17aec810cd7c70c5b9fab)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 7b9a3a91

drivers/gpu/drm/xe/xe_pxp.c

+1 −0
Original line number Diff line number Diff line
@@ -583,6 +583,7 @@ static int pxp_start(struct xe_pxp *pxp, u8 type) 
			drm_err(&pxp->xe->drm, "PXP termination failed before start\n");

			mutex_lock(&pxp->mutex);

			pxp->status = XE_PXP_ERROR;

			complete_all(&pxp->termination);



			goto out_unlock;

		}