Commit e269537e authored by Li Nan's avatar Li Nan Committed by Jens Axboe
Browse files

block: clean up the check in blkdev_iomap_begin() 



It is odd to check the offset amidst a series of assignments. Moving this
check to the beginning of the function makes the code look better.

Signed-off-by: default avatarLi Nan <linan122@huawei.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240625115517.1472120-1-linan666@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 69b65176

block/fops.c

+3 −2
Original line number Diff line number Diff line
@@ -394,10 +394,11 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, 
	struct block_device *bdev = I_BDEV(inode);

	loff_t isize = i_size_read(inode);



	iomap->bdev = bdev;

	iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev));

	if (offset >= isize)

		return -EIO;



	iomap->bdev = bdev;

	iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev));

	iomap->type = IOMAP_MAPPED;

	iomap->addr = iomap->offset;

	iomap->length = isize - iomap->offset;