Commit e26e2d2e authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix bug on trap in smb2_lock 



If lock count is greater than 1, flags could be old value.
It should be checked with flags of smb_lock, not flags.
It will cause bug-on trap from locks_free_lock in error handling
routine.

Cc: stable@vger.kernel.org
Reported-by: default avatarNorbert Szetei <norbert@doyensec.com>
Tested-by: default avatarNorbert Szetei <norbert@doyensec.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 84d2d164

fs/smb/server/smb2pdu.c

+1 −1
Original line number Diff line number Diff line
@@ -7468,7 +7468,7 @@ int smb2_lock(struct ksmbd_work *work) 
retry:

		rc = vfs_lock_file(filp, smb_lock->cmd, flock, NULL);

skip:

		if (flags & SMB2_LOCKFLAG_UNLOCK) {

		if (smb_lock->flags & SMB2_LOCKFLAG_UNLOCK) {

			if (!rc) {

				ksmbd_debug(SMB, "File unlocked\n");

			} else if (rc == -ENOENT) {