Unverified Commit e26ff429 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: stm32: sai: fix device leak on probe 



Make sure to drop the reference taken when looking up the sync provider
device and its driver data during DAI probe on probe failures and on
unbind.

Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.

Fixes: 7dd0d835 ("ASoC: stm32: sai: simplify sync modes management")
Fixes: 1c3816a1 ("ASoC: stm32: sai: add missing put_device()")
Cc: stable@vger.kernel.org	# 4.16: 1c3816a1
Cc: olivier moysan <olivier.moysan@st.com>
Cc: Wen Yang <yellowriver2010@hotmail.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarolivier moysan <olivier.moysan@foss.st.com>
Link: https://patch.msgid.link/20251124104908.15754-2-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ac3fd01e

sound/soc/stm/stm32_sai.c

+1 −1
Original line number Diff line number Diff line
@@ -143,6 +143,7 @@ static int stm32_sai_set_sync(struct stm32_sai_data *sai_client, 
	}



	sai_provider = platform_get_drvdata(pdev);

	put_device(&pdev->dev);

	if (!sai_provider) {

		dev_err(&sai_client->pdev->dev,

			"SAI sync provider data not found\n");
@@ -159,7 +160,6 @@ static int stm32_sai_set_sync(struct stm32_sai_data *sai_client, 
	ret = stm32_sai_sync_conf_provider(sai_provider, synco);



error:

	put_device(&pdev->dev);

	of_node_put(np_provider);

	return ret;

}