Commit e275e19c authored Jun 14, 2024 by Shradha Gupta Committed by Jakub Kicinski Jun 17, 2024

net: mana: Use mana_cleanup_port_context() for rxq cleanup



To cleanup rxqs in port context structures, instead of duplicating the
code, use existing function mana_cleanup_port_context() which does
the exact cleanup that's needed.

Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
Link: https://lore.kernel.org/r/1718349548-28697-1-git-send-email-shradhagupta@linux.microsoft.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent dd89a81d

drivers/net/ethernet/microsoft/mana/mana_en.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev)
		return 0;

		reset_apc:
		kfree(apc->rxqs);
		apc->rxqs = NULL;
		mana_cleanup_port_context(apc);
		return err;
		}

		@@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
		free_indir:
		mana_cleanup_indir_table(apc);
		reset_apc:
		kfree(apc->rxqs);
		apc->rxqs = NULL;
		mana_cleanup_port_context(apc);
		free_net:
		*ndev_storage = NULL;
		netdev_err(ndev, "Failed to probe vPort %d: %d\n", port_idx, err);