Commit e282c89b authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

staging: gpib: pc2: avoid calling undefined dma_free() 



On architectures that don't support the ISA DMA API, this causes a build
failure. The corresponding dma_alloc() call is already in an #ifdef,
so use the same one for dma_free().

Note that nothing seems to set PC2_DMA, so parts of this driver
are likely unused. ISA DMA usually does not work on PCI or PCMCIA
devices, only on physical ISA slots.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20241016111521.1143191-4-arnd@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b8989f45

drivers/staging/gpib/pc2/pc2_gpib.c

+4 −0
Original line number Diff line number Diff line
@@ -462,8 +462,10 @@ void pc2_detach(gpib_board_t *board) 


	if (pc2_priv) {

		nec_priv = &pc2_priv->nec7210_priv;

#ifdef PC2_DMA

		if (nec_priv->dma_channel)

			free_dma(nec_priv->dma_channel);

#endif

		gpib_free_pseudo_irq(board);

		if (pc2_priv->irq)

			free_irq(pc2_priv->irq, board);
@@ -596,8 +598,10 @@ static void pc2a_common_detach(gpib_board_t *board, unsigned int num_registers) 


	if (pc2_priv) {

		nec_priv = &pc2_priv->nec7210_priv;

#ifdef PC2_DMA

		if (nec_priv->dma_channel)

			free_dma(nec_priv->dma_channel);

#endif

		gpib_free_pseudo_irq(board);

		if (pc2_priv->irq)

			free_irq(pc2_priv->irq, board);