Unverified Commit e2ab5f60 authored by Onur Özkan's avatar Onur Özkan Committed by Mark Brown
Browse files

rust: regulator: use `to_result` for error handling 



Simplifies error handling by replacing the manual check
of the return value with the `to_result` helper.

Signed-off-by: default avatarOnur Özkan <work@onurozkan.dev>
Reviewed-by: default avatarDaniel Almeida <daniel.almeida@collabora.com>
Message-ID: <20250821090720.23939-1-work@onurozkan.dev>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ec0be3cd

rust/kernel/regulator.rs

+2 −5
Original line number Diff line number Diff line
@@ -267,11 +267,8 @@ pub fn set_voltage(&self, min_voltage: Voltage, max_voltage: Voltage) -> Result 
    pub fn get_voltage(&self) -> Result<Voltage> {

        // SAFETY: Safe as per the type invariants of `Regulator`.

        let voltage = unsafe { bindings::regulator_get_voltage(self.inner.as_ptr()) };

        if voltage < 0 {

            Err(kernel::error::Error::from_errno(voltage))

        } else {

            Ok(Voltage::from_microvolts(voltage))

        }



        to_result(voltage).map(|()| Voltage::from_microvolts(voltage))

    }



    fn get_internal(dev: &Device, name: &CStr) -> Result<Regulator<T>> {