Unverified Commit e2b5f1da authored by Carlos Eduardo Gallo Filho's avatar Carlos Eduardo Gallo Filho Committed by Maxime Ripard
Browse files

drm/tests: Add parameters to the drm_test_framebuffer_create test 



Extend the existing test case to cover:
1. Invalid flag atribute in the struct drm_mode_fb_cmd2.
2. Pixel format which requires non-linear modifier with
DRM_FORMAT_MOD_LINEAR set.
3. Buffer offset for inexistent plane

Signed-off-by: default avatarCarlos Eduardo Gallo Filho <gcarlos@disroot.org>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240911001559.28284-3-gcarlos@disroot.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 96d068ea

drivers/gpu/drm/tests/drm_framebuffer_test.c

+27 −0
Original line number Diff line number Diff line
@@ -21,6 +21,8 @@ 
#define MIN_HEIGHT 4

#define MAX_HEIGHT 4096



#define DRM_MODE_FB_INVALID BIT(2)



struct drm_framebuffer_test {

	int buffer_created;

	struct drm_mode_fb_cmd2 cmd;
@@ -85,6 +87,24 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = { 
		 .pitches = { 4 * MAX_WIDTH, 0, 0 },

	}

},



/*

 * All entries in members that represents per-plane values (@modifier, @handles,

 * @pitches and @offsets) must be zero when unused.

 */

{ .buffer_created = 0, .name = "ABGR8888 Buffer offset for inexistent plane",

	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,

		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, UINT_MAX / 2, 0 },

		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,

	}

},



{ .buffer_created = 0, .name = "ABGR8888 Invalid flag",

	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,

		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },

		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_INVALID,

	}

},

{ .buffer_created = 1, .name = "ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers",

	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,

		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
@@ -264,6 +284,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = { 
		 .pitches = { MAX_WIDTH, DIV_ROUND_UP(MAX_WIDTH, 2), DIV_ROUND_UP(MAX_WIDTH, 2) },

	}

},

{ .buffer_created = 0, .name = "YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)",

	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_YUV420_10BIT,

		 .handles = { 1, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,

		 .modifier = { DRM_FORMAT_MOD_LINEAR, 0, 0 },

		 .pitches = { MAX_WIDTH, 0, 0 },

	}

},

{ .buffer_created = 1, .name = "X0L2 Normal sizes",

	.cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_X0L2,

		 .handles = { 1, 0, 0 }, .pitches = { 1200, 0, 0 }