Unverified Commit e2d7ad71 authored by Simon Trimmer's avatar Simon Trimmer Committed by Mark Brown
Browse files

ASoC: cs-amp-lib: Check for no firmware controls when writing calibration 



When a wmfw file has not been loaded the firmware control descriptions
necessary to write a stored calibration are not present. In this case
print a more descriptive error message.

The message is logged at info level because it is not fatal, and does
not necessarily imply that anything is broken.

Signed-off-by: default avatarSimon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://msgid.link/r/20240325144450.293630-1-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c61115b3

sound/soc/codecs/cs-amp-lib.c

+5 −0
Original line number Diff line number Diff line
@@ -56,6 +56,11 @@ static int _cs_amp_write_cal_coeffs(struct cs_dsp *dsp, 
	dev_dbg(dsp->dev, "Calibration: Ambient=%#x, Status=%#x, CalR=%d\n",

		data->calAmbient, data->calStatus, data->calR);



	if (list_empty(&dsp->ctl_list)) {

		dev_info(dsp->dev, "Calibration disabled due to missing firmware controls\n");

		return -ENOENT;

	}



	ret = cs_amp_write_cal_coeff(dsp, controls, controls->ambient, data->calAmbient);

	if (ret)

		return ret;