Commit e2f10527 authored by Kalesh AP's avatar Kalesh AP Committed by Leon Romanovsky
Browse files

RDMA/bnxt_re: Fix issue in the unload path 



The cited comment removed the netdev notifier register call
from the driver. But, it did not remove the cleanup code from
the unload path. As a result, driver unload is not clean and
resulted in undesired behaviour.

Fixes: d3b15fcc ("RDMA/bnxt_re: Remove deliver net device event")
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Link: https://patch.msgid.link/1738657285-23968-4-git-send-email-selvin.xavier@broadcom.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent f0df225d

drivers/infiniband/hw/bnxt_re/bnxt_re.h

+0 −1
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ struct bnxt_re_dev { 
#define BNXT_RE_FLAG_ISSUE_ROCE_STATS          29

	struct net_device		*netdev;

	struct auxiliary_device         *adev;

	struct notifier_block		nb;

	unsigned int			version, major, minor;

	struct bnxt_qplib_chip_ctx	*chip_ctx;

	struct bnxt_en_dev		*en_dev;

drivers/infiniband/hw/bnxt_re/main.c

+0 −10
Original line number Diff line number Diff line
@@ -1359,7 +1359,6 @@ static struct bnxt_re_dev *bnxt_re_dev_add(struct auxiliary_device *adev, 
		return NULL;

	}

	/* Default values */

	rdev->nb.notifier_call = NULL;

	rdev->netdev = en_dev->net;

	rdev->en_dev = en_dev;

	rdev->adev = adev;
@@ -2354,15 +2353,6 @@ static int bnxt_re_add_device(struct auxiliary_device *adev, u8 op_type) 
static void bnxt_re_remove_device(struct bnxt_re_dev *rdev, u8 op_type,

				  struct auxiliary_device *aux_dev)

{

	if (rdev->nb.notifier_call) {

		unregister_netdevice_notifier(&rdev->nb);

		rdev->nb.notifier_call = NULL;

	} else {

		/* If notifier is null, we should have already done a

		 * clean up before coming here.

		 */

		return;

	}

	bnxt_re_setup_cc(rdev, false);

	ib_unregister_device(&rdev->ibdev);

	bnxt_re_dev_uninit(rdev, op_type);