Unverified Commit e2ff3bd8 authored by Mark Brown's avatar Mark Brown
Browse files

ASoC: SOF: Intel: Add fw_regs area to debugfs map for 

Merge series from Peter Ujfalusi <peter.ujfalusi@linux.intel.com>:

The beginning of the first SRAM window contains various fw registers and
additional information which can be very beneficial to read to gather
information on the current states to debug issues.
parents f78bf2c9 61faefa2

sound/soc/sof/intel/lnl.c

+1 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ static const struct snd_sof_debugfs_map lnl_dsp_debugfs[] = { 
	{"hda", HDA_DSP_HDA_BAR, 0, 0x4000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"pp", HDA_DSP_PP_BAR,  0, 0x1000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"fw_regs", HDA_DSP_BAR,  MTL_SRAM_WINDOW_OFFSET(0), 0x1000, SOF_DEBUGFS_ACCESS_D0_ONLY},

};



/* this helps allows the DSP to setup DMIC/SSP */

sound/soc/sof/intel/mtl.c

+1 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ static const struct snd_sof_debugfs_map mtl_dsp_debugfs[] = { 
	{"hda", HDA_DSP_HDA_BAR, 0, 0x4000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"pp", HDA_DSP_PP_BAR,  0, 0x1000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"fw_regs", HDA_DSP_BAR,  MTL_SRAM_WINDOW_OFFSET(0), 0x1000, SOF_DEBUGFS_ACCESS_D0_ONLY},

};



static void mtl_ipc_host_done(struct snd_sof_dev *sdev)

sound/soc/sof/intel/tgl.c

+11 −4
Original line number Diff line number Diff line
@@ -22,6 +22,13 @@ static const struct snd_sof_debugfs_map tgl_dsp_debugfs[] = { 
	{"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},

};



static const struct snd_sof_debugfs_map tgl_ipc4_dsp_debugfs[] = {

	{"hda", HDA_DSP_HDA_BAR, 0, 0x4000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"pp", HDA_DSP_PP_BAR,  0, 0x1000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"dsp", HDA_DSP_BAR,  0, 0x10000, SOF_DEBUGFS_ACCESS_ALWAYS},

	{"fw_regs", HDA_DSP_BAR,  SRAM_WINDOW_OFFSET(0), 0x1000, SOF_DEBUGFS_ACCESS_D0_ONLY},

};



static int tgl_dsp_core_get(struct snd_sof_dev *sdev, int core)

{

	const struct sof_ipc_pm_ops *pm_ops = sdev->ipc->ops->pm;
@@ -75,6 +82,8 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev) 


		/* debug */

		sof_tgl_ops.ipc_dump	= cnl_ipc_dump;

		sof_tgl_ops.debug_map	= tgl_dsp_debugfs;

		sof_tgl_ops.debug_map_count = ARRAY_SIZE(tgl_dsp_debugfs);



		sof_tgl_ops.set_power_state = hda_dsp_set_power_state_ipc3;

	}
@@ -105,6 +114,8 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev) 
		/* debug */

		sof_tgl_ops.ipc_dump	= cnl_ipc4_dump;

		sof_tgl_ops.dbg_dump	= hda_ipc4_dsp_dump;

		sof_tgl_ops.debug_map	= tgl_ipc4_dsp_debugfs;

		sof_tgl_ops.debug_map_count = ARRAY_SIZE(tgl_ipc4_dsp_debugfs);



		sof_tgl_ops.set_power_state = hda_dsp_set_power_state_ipc4;

	}
@@ -112,10 +123,6 @@ int sof_tgl_ops_init(struct snd_sof_dev *sdev) 
	/* set DAI driver ops */

	hda_set_dai_drv_ops(sdev, &sof_tgl_ops);



	/* debug */

	sof_tgl_ops.debug_map	= tgl_dsp_debugfs;

	sof_tgl_ops.debug_map_count	= ARRAY_SIZE(tgl_dsp_debugfs);



	/* pre/post fw run */

	sof_tgl_ops.post_fw_run = hda_dsp_post_fw_run;