Commit e31eee4a authored by Billy Tsai's avatar Billy Tsai Committed by Bartosz Golaszewski
Browse files

gpio: aspeed: fix AST2700 debounce selector bit definitions 



The AST2700 datasheet defines reg_debounce_sel1 as the low bit and
reg_debounce_sel2 as the high bit. The current driver uses the AST2600
mapping instead, where sel1 is the high bit and sel2 is the low bit.

As a result, the debounce selector bits are programmed in reverse on
AST2700. Swap the G7 sel1/sel2 bit definitions so the driver matches the
hardware definition.

Fixes: b2e861bd ("gpio: aspeed: Support G7 Aspeed gpio controller")
Signed-off-by: default avatarBilly Tsai <billy_tsai@aspeedtech.com>
Link: https://patch.msgid.link/20260415-gpio-fix-v1-1-b08a89b31e6f@aspeedtech.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent 5cd9c6d3

drivers/gpio/gpio-aspeed.c

+2 −2
Original line number Diff line number Diff line
@@ -42,8 +42,8 @@ 
#define GPIO_G7_CTRL_IRQ_TYPE1 BIT(4)

#define GPIO_G7_CTRL_IRQ_TYPE2 BIT(5)

#define GPIO_G7_CTRL_RST_TOLERANCE BIT(6)

#define GPIO_G7_CTRL_DEBOUNCE_SEL1 BIT(7)

#define GPIO_G7_CTRL_DEBOUNCE_SEL2 BIT(8)

#define GPIO_G7_CTRL_DEBOUNCE_SEL2 BIT(7)

#define GPIO_G7_CTRL_DEBOUNCE_SEL1 BIT(8)

#define GPIO_G7_CTRL_INPUT_MASK BIT(9)

#define GPIO_G7_CTRL_IRQ_STS BIT(12)

#define GPIO_G7_CTRL_IN_DATA BIT(13)