Commit e343678e authored by Thorsten Blum's avatar Thorsten Blum Committed by Anna Schumaker
Browse files

nfs: Remove unnecessary NULL check before kfree() 



Since kfree() already checks if its argument is NULL, an additional
check before calling kfree() is unnecessary and can be removed.

Remove it and thus also the following Coccinelle/coccicheck warning
reported by ifnullfree.cocci:

  WARNING: NULL check before some freeing functions is not needed

Reviewed-by: default avatarBenjamin Coddington <bcodding@redhat.com>
Signed-off-by: default avatarThorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarAnna Schumaker <anna.schumaker@oracle.com>
parent bb8e4ce5

fs/nfs/read.c

+1 −2
Original line number Diff line number Diff line
@@ -48,7 +48,6 @@ static struct nfs_pgio_header *nfs_readhdr_alloc(void) 


static void nfs_readhdr_free(struct nfs_pgio_header *rhdr)

{

	if (rhdr->res.scratch != NULL)

	kfree(rhdr->res.scratch);

	kmem_cache_free(nfs_rdata_cachep, rhdr);

}