Commit e35bc5d8 authored by Christian Marangi's avatar Christian Marangi Committed by Lee Jones
Browse files

leds: leds-lp55xx: Generalize turn_off_channels function 



Generalize turn_off_channels function as the implementation is the same for
most of the lp55xx based LED driver.

Suggested-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20240626160027.19703-14-ansuelsmth@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 01e0290d

drivers/leds/leds-lp5523.c

+1 −9
Original line number Diff line number Diff line
@@ -167,20 +167,12 @@ static void lp5523_stop_engine(struct lp55xx_chip *chip) 
	lp5523_wait_opmode_done();

}



static void lp5523_turn_off_channels(struct lp55xx_chip *chip)

{

	int i;



	for (i = 0; i < LP5523_MAX_LEDS; i++)

		lp55xx_write(chip, LP5523_REG_LED_PWM_BASE + i, 0);

}



static void lp5523_run_engine(struct lp55xx_chip *chip, bool start)

{

	/* stop engine */

	if (!start) {

		lp5523_stop_engine(chip);

		lp5523_turn_off_channels(chip);

		lp55xx_turn_off_channels(chip);

		return;

	}

drivers/leds/leds-lp55xx-common.c

+10 −0
Original line number Diff line number Diff line
@@ -288,6 +288,16 @@ void lp55xx_set_led_current(struct lp55xx_led *led, u8 led_current) 
}

EXPORT_SYMBOL_GPL(lp55xx_set_led_current);



void lp55xx_turn_off_channels(struct lp55xx_chip *chip)

{

	const struct lp55xx_device_config *cfg = chip->cfg;

	int i;



	for (i = 0; i < cfg->max_channel; i++)

		lp55xx_write(chip, cfg->reg_led_pwm_base.addr + i, 0);

}

EXPORT_SYMBOL_GPL(lp55xx_turn_off_channels);



static void lp55xx_reset_device(struct lp55xx_chip *chip)

{

	const struct lp55xx_device_config *cfg = chip->cfg;

drivers/leds/leds-lp55xx-common.h

+1 −0
Original line number Diff line number Diff line
@@ -220,6 +220,7 @@ extern void lp55xx_firmware_loaded_cb(struct lp55xx_chip *chip); 
extern int lp55xx_led_brightness(struct lp55xx_led *led);

extern int lp55xx_multicolor_brightness(struct lp55xx_led *led);

extern void lp55xx_set_led_current(struct lp55xx_led *led, u8 led_current);

extern void lp55xx_turn_off_channels(struct lp55xx_chip *chip);



/* common probe/remove function */

extern int lp55xx_probe(struct i2c_client *client);

drivers/leds/leds-lp8501.c

+1 −9
Original line number Diff line number Diff line
@@ -110,20 +110,12 @@ static int lp8501_post_init_device(struct lp55xx_chip *chip) 
				LP8501_PWR_CONFIG_M, chip->pdata->pwr_sel);

}



static void lp8501_turn_off_channels(struct lp55xx_chip *chip)

{

	int i;



	for (i = 0; i < LP8501_MAX_LEDS; i++)

		lp55xx_write(chip, LP8501_REG_LED_PWM_BASE + i, 0);

}



static void lp8501_run_engine(struct lp55xx_chip *chip, bool start)

{

	/* stop engine */

	if (!start) {

		lp55xx_stop_all_engine(chip);

		lp8501_turn_off_channels(chip);

		lp55xx_turn_off_channels(chip);

		return;

	}