Commit e3ac93e9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Johannes Berg
Browse files

wifi: mwifiex: fix double free in mwifiex_send_rgpower_table() 



The "hostcmd" is freed using cleanup.h, so calling kfree() will lead to
a double free.  Delete the kfree().

Fixes: 7b6f16a2 ("wifi: mwifiex: add rgpower table loading support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarFrancesco Dolcini <francesco.dolcini@toradex.com>
Link: https://patch.msgid.link/aLqZBh5_dSHUb4AE@stanley.mountain


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent e53f8b12

drivers/net/wireless/marvell/mwifiex/sta_cmd.c

+1 −3
Original line number Diff line number Diff line
@@ -1521,10 +1521,8 @@ int mwifiex_send_rgpower_table(struct mwifiex_private *priv, const u8 *data, 
		return -ENOMEM;



	_data = kmemdup(data, size, GFP_KERNEL);

	if (!_data) {

		kfree(hostcmd);

	if (!_data)

		return -ENOMEM;

	}



	pos = _data;

	ptr = hostcmd->cmd;