Commit e3b0311f authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

wifi: mt76: mt7996: rely on shared poll_list field 



Rely on poll_list field in mt76_wcid  structure and get rid of
private copy.

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 9d599f2d

drivers/net/wireless/mediatek/mt76/mt7996/mac.c

+8 −8
Original line number Diff line number Diff line
@@ -130,8 +130,8 @@ static void mt7996_mac_sta_poll(struct mt7996_dev *dev) 
			break;

		}

		msta = list_first_entry(&sta_poll_list,

					struct mt7996_sta, poll_list);

		list_del_init(&msta->poll_list);

					struct mt7996_sta, wcid.poll_list);

		list_del_init(&msta->wcid.poll_list);

		spin_unlock_bh(&dev->mt76.sta_poll_lock);



		idx = msta->wcid.idx;
@@ -682,8 +682,8 @@ mt7996_mac_fill_rx(struct mt7996_dev *dev, struct sk_buff *skb) 


		msta = container_of(status->wcid, struct mt7996_sta, wcid);

		spin_lock_bh(&dev->mt76.sta_poll_lock);

		if (list_empty(&msta->poll_list))

			list_add_tail(&msta->poll_list,

		if (list_empty(&msta->wcid.poll_list))

			list_add_tail(&msta->wcid.poll_list,

				      &dev->mt76.sta_poll_list);

		spin_unlock_bh(&dev->mt76.sta_poll_lock);

	}
@@ -1293,8 +1293,8 @@ mt7996_mac_tx_free(struct mt7996_dev *dev, void *data, int len) 


			msta = container_of(wcid, struct mt7996_sta, wcid);

			spin_lock_bh(&mdev->sta_poll_lock);

			if (list_empty(&msta->poll_list))

				list_add_tail(&msta->poll_list,

			if (list_empty(&msta->wcid.poll_list))

				list_add_tail(&msta->wcid.poll_list,

					      &mdev->sta_poll_list);

			spin_unlock_bh(&mdev->sta_poll_lock);

			continue;
@@ -1502,8 +1502,8 @@ static void mt7996_mac_add_txs(struct mt7996_dev *dev, void *data) 
		goto out;



	spin_lock_bh(&dev->mt76.sta_poll_lock);

	if (list_empty(&msta->poll_list))

		list_add_tail(&msta->poll_list, &dev->mt76.sta_poll_list);

	if (list_empty(&msta->wcid.poll_list))

		list_add_tail(&msta->wcid.poll_list, &dev->mt76.sta_poll_list);

	spin_unlock_bh(&dev->mt76.sta_poll_lock);



out:

drivers/net/wireless/mediatek/mt76/mt7996/main.c

+6 −6
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static int mt7996_add_interface(struct ieee80211_hw *hw, 
	idx = MT7996_WTBL_RESERVED - mvif->mt76.idx;



	INIT_LIST_HEAD(&mvif->sta.rc_list);

	INIT_LIST_HEAD(&mvif->sta.poll_list);

	INIT_LIST_HEAD(&mvif->sta.wcid.poll_list);

	mvif->sta.wcid.idx = idx;

	mvif->sta.wcid.phy_idx = band_idx;

	mvif->sta.wcid.hw_key_idx = -1;
@@ -264,8 +264,8 @@ static void mt7996_remove_interface(struct ieee80211_hw *hw, 
	mutex_unlock(&dev->mt76.mutex);



	spin_lock_bh(&dev->mt76.sta_poll_lock);

	if (!list_empty(&msta->poll_list))

		list_del_init(&msta->poll_list);

	if (!list_empty(&msta->wcid.poll_list))

		list_del_init(&msta->wcid.poll_list);

	spin_unlock_bh(&dev->mt76.sta_poll_lock);



	mt76_packet_id_flush(&dev->mt76, &msta->wcid);
@@ -654,7 +654,7 @@ int mt7996_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif, 
		return -ENOSPC;



	INIT_LIST_HEAD(&msta->rc_list);

	INIT_LIST_HEAD(&msta->poll_list);

	INIT_LIST_HEAD(&msta->wcid.poll_list);

	msta->vif = mvif;

	msta->wcid.sta = 1;

	msta->wcid.idx = idx;
@@ -690,8 +690,8 @@ void mt7996_mac_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif, 
		mt7996_mac_twt_teardown_flow(dev, msta, i);



	spin_lock_bh(&mdev->sta_poll_lock);

	if (!list_empty(&msta->poll_list))

		list_del_init(&msta->poll_list);

	if (!list_empty(&msta->wcid.poll_list))

		list_del_init(&msta->wcid.poll_list);

	if (!list_empty(&msta->rc_list))

		list_del_init(&msta->rc_list);

	spin_unlock_bh(&mdev->sta_poll_lock);

drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h

+0 −1
Original line number Diff line number Diff line
@@ -103,7 +103,6 @@ struct mt7996_sta { 


	struct mt7996_vif *vif;



	struct list_head poll_list;

	struct list_head rc_list;

	u32 airtime_ac[8];