Unverified Commit e3fb5798 authored by Daniele Ceraolo Spurio's avatar Daniele Ceraolo Spurio Committed by Rodrigo Vivi
Browse files

drm/xe/pxp: Don't allow PXP on older PTL GSC FWs 



On PTL, older GSC FWs have a bug that can cause them to crash during
PXP invalidation events, which leads to a complete loss of power
management on the media GT. Therefore, we can't use PXP on FWs that
have this bug, which was fixed in PTL GSC build 1396.

Fixes: b1dcec9b ("drm/xe/ptl: Enable PXP for PTL")
Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Reviewed-by: default avatarJulia Filipchuk <julia.filipchuk@intel.com>
Acked-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patch.msgid.link/20260324153718.3155504-10-daniele.ceraolospurio@intel.com


(cherry picked from commit 6eb04caaa972934c9b6cea0e0c29e466bf9a346f)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 76903b20

drivers/gpu/drm/xe/xe_pxp.c

+12 −0
Original line number Diff line number Diff line
@@ -380,6 +380,18 @@ int xe_pxp_init(struct xe_device *xe) 
		return 0;

	}



	/*

	 * On PTL, older GSC FWs have a bug that can cause them to crash during

	 * PXP invalidation events, which leads to a complete loss of power

	 * management on the media GT. Therefore, we can't use PXP on FWs that

	 * have this bug, which was fixed in PTL GSC build 1396.

	 */

	if (xe->info.platform == XE_PANTHERLAKE &&

	    gt->uc.gsc.fw.versions.found[XE_UC_FW_VER_RELEASE].build < 1396) {

		drm_info(&xe->drm, "PXP requires PTL GSC build 1396 or newer\n");

		return 0;

	}



	pxp = drmm_kzalloc(&xe->drm, sizeof(struct xe_pxp), GFP_KERNEL);

	if (!pxp) {

		err = -ENOMEM;