Commit e3ffbcac authored by Abdun Nihaal's avatar Abdun Nihaal Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove unused field pdata 



The field pdata in struct recv_buf is set but not used.
Remove it.

Also remove rtl8188eu_init_recvbuf function as it does nothing now.

Signed-off-by: default avatarAbdun Nihaal <abdun.nihaal@gmail.com>
Link: https://lore.kernel.org/r/7fe9ed2c6eade65c118511228283ef9d92ea4b43.1646321515.git.abdun.nihaal@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cd711066

drivers/staging/r8188eu/hal/rtl8188eu_recv.c

+0 −7
Original line number Diff line number Diff line
@@ -12,13 +12,6 @@ 


#include "../include/rtl8188e_hal.h"



void rtl8188eu_init_recvbuf(struct recv_buf *precvbuf)

{

	if (precvbuf->pbuf) {

		precvbuf->pdata = precvbuf->pbuf;

	}

}



int	rtl8188eu_init_recv_priv(struct adapter *padapter)

{

	struct recv_priv	*precvpriv = &padapter->recvpriv;

drivers/staging/r8188eu/hal/usb_ops_linux.c

+0 −4
Original line number Diff line number Diff line
@@ -428,8 +428,6 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem) 
			precvbuf->reuse = true;

	}



	rtl8188eu_init_recvbuf(precvbuf);



	/* re-assign for linux based on skb */

	if (!precvbuf->reuse || !precvbuf->pskb) {

		precvbuf->pskb = netdev_alloc_skb(adapter->pnetdev, MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ);
@@ -440,10 +438,8 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem) 
		alignment = tmpaddr & (RECVBUFF_ALIGN_SZ - 1);

		skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));



		precvbuf->pdata = precvbuf->pskb->data;

		precvbuf->pbuf = precvbuf->pskb->data;

	} else { /* reuse skb */

		precvbuf->pdata = precvbuf->pskb->data;

		precvbuf->pbuf = precvbuf->pskb->data;



		precvbuf->reuse = false;

drivers/staging/r8188eu/include/rtl8188e_recv.h

+0 −1
Original line number Diff line number Diff line
@@ -37,7 +37,6 @@ enum rx_packet_type { 
	HIS_REPORT,/*  USB HISR RPT */

};



void rtl8188eu_init_recvbuf(struct recv_buf *buf);

s32 rtl8188eu_init_recv_priv(struct adapter *padapter);

void rtl8188eu_free_recv_priv(struct adapter * padapter);

void rtl8188eu_recv_hdl(struct adapter * padapter, struct recv_buf *precvbuf);

drivers/staging/r8188eu/include/rtw_recv.h

+0 −1
Original line number Diff line number Diff line
@@ -210,7 +210,6 @@ struct recv_buf { 
	struct adapter *adapter;

	u8	*pbuf;

	u8	*pallocated_buf;

	u8	*pdata;

	struct urb *purb;

	dma_addr_t dma_transfer_addr;	/* (in) dma addr for transfer_buffer */

	u32 alloc_sz;

drivers/staging/r8188eu/os_dep/recv_linux.c

+0 −1
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter, 
	precvbuf->reuse = false;

	precvbuf->pallocated_buf = NULL;

	precvbuf->pbuf = NULL;

	precvbuf->pdata = NULL;

	return res;

}