Commit e403cfff authored by justinstitt@google.com's avatar justinstitt@google.com Committed by David S. Miller
Browse files

net: Convert some ethtool_sprintf() to ethtool_puts()



This patch converts some basic cases of ethtool_sprintf() to
ethtool_puts().

The conversions are used in cases where ethtool_sprintf() was being used
with just two arguments:
|       ethtool_sprintf(&data, buffer[i].name);
or when it's used with format string: "%s"
|       ethtool_sprintf(&data, "%s", buffer[i].name);
which both now become:
|       ethtool_puts(&data, buffer[i].name);

Signed-off-by: default avatarJustin Stitt <justinstitt@google.com>
Reviewed-by: default avatarWei Fang <wei.fang@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarLouis Peens <louis.peens@corigine.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9b5f621c
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1759,7 +1759,7 @@ static void gswip_get_strings(struct dsa_switch *ds, int port, u32 stringset,
		return;

	for (i = 0; i < ARRAY_SIZE(gswip_rmon_cnt); i++)
		ethtool_sprintf(&data, "%s", gswip_rmon_cnt[i].name);
		ethtool_puts(&data, gswip_rmon_cnt[i].name);
}

static u32 gswip_bcm_ram_entry_read(struct gswip_priv *priv, u32 table,
+1 −1
Original line number Diff line number Diff line
@@ -836,7 +836,7 @@ mt7530_get_strings(struct dsa_switch *ds, int port, u32 stringset,
		return;

	for (i = 0; i < ARRAY_SIZE(mt7530_mib); i++)
		ethtool_sprintf(&data, "%s", mt7530_mib[i].name);
		ethtool_puts(&data, mt7530_mib[i].name);
}

static void
+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ void qca8k_get_strings(struct dsa_switch *ds, int port, u32 stringset,
		return;

	for (i = 0; i < priv->info->mib_count; i++)
		ethtool_sprintf(&data, "%s", ar8327_mib[i].name);
		ethtool_puts(&data, ar8327_mib[i].name);
}

void qca8k_get_ethtool_stats(struct dsa_switch *ds, int port,
+1 −1
Original line number Diff line number Diff line
@@ -1303,7 +1303,7 @@ static void rtl8365mb_get_strings(struct dsa_switch *ds, int port, u32 stringset

	for (i = 0; i < RTL8365MB_MIB_END; i++) {
		struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
		ethtool_sprintf(&data, "%s", mib->name);
		ethtool_puts(&data, mib->name);
	}
}

+1 −1
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ void rtl8366_get_strings(struct dsa_switch *ds, int port, u32 stringset,
		return;

	for (i = 0; i < priv->num_mib_counters; i++)
		ethtool_sprintf(&data, "%s", priv->mib_counters[i].name);
		ethtool_puts(&data, priv->mib_counters[i].name);
}
EXPORT_SYMBOL_GPL(rtl8366_get_strings);

Loading