Commit e406737b authored by Kees Cook's avatar Kees Cook
Browse files

seccomp: Constify sysctl subhelpers 



The read_actions_logged() and write_actions_logged() helpers called by the
sysctl proc handler seccomp_actions_logged_handler() are already expecting
their sysctl table argument to be read-only. Actually mark the argument
as const in preparation[1] for global constification of the sysctl tables.

Suggested-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/lkml/20240423-sysctl-const-handler-v3-11-e0beccb836e2@weissschuh.net/

 [1]
Reviewed-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Reviewed-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20240508171337.work.861-kees@kernel.org


Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent 39cd87c4

kernel/seccomp.c

+2 −2
Original line number Diff line number Diff line
@@ -2334,7 +2334,7 @@ static bool seccomp_actions_logged_from_names(u32 *actions_logged, char *names) 
	return true;

}



static int read_actions_logged(struct ctl_table *ro_table, void *buffer,

static int read_actions_logged(const struct ctl_table *ro_table, void *buffer,

			       size_t *lenp, loff_t *ppos)

{

	char names[sizeof(seccomp_actions_avail)];
@@ -2352,7 +2352,7 @@ static int read_actions_logged(struct ctl_table *ro_table, void *buffer, 
	return proc_dostring(&table, 0, buffer, lenp, ppos);

}



static int write_actions_logged(struct ctl_table *ro_table, void *buffer,

static int write_actions_logged(const struct ctl_table *ro_table, void *buffer,

				size_t *lenp, loff_t *ppos, u32 *actions_logged)

{

	char names[sizeof(seccomp_actions_avail)];