Commit e40d16e6 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI/pwrctrl: slot: Rename private struct and pointers for consistency 



Previously the pwrseq, tc9563, and slot pwrctrl drivers used different
naming conventions for their private data structs and pointers to them,
which makes patches hard to read.

Rename structs, variables, and functions to reduce boiler-plate and start
with "slot":

  struct pci_pwrctrl_slot_data      -> struct slot_pwrctrl
  struct pci_pwrctrl ctx            -> struct pci_pwrctrl pwrctrl
  pci_pwrctrl_slot_probe()          -> slot_pwrctrl_probe()
  pci_pwrctrl_slot_of_match[]       -> slot_pwrctrl_of_match[]
  pci_pwrctrl_slot_driver           -> slot_pwrctrl_driver
  devm_pci_pwrctrl_slot_power_off() -> devm_slot_pwrctrl_power_off()

No functional change intended.

[bhelgaas: move "slot" to beginning, also rename functions, etc]
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260115-pci-pwrctrl-rework-v5-2-9d26da3ce903@oss.qualcomm.com
parent 2ba7c7bd

drivers/pci/pwrctrl/slot.c

+15 −15
Original line number Diff line number Diff line
@@ -13,23 +13,23 @@ 
#include <linux/regulator/consumer.h>

#include <linux/slab.h>



struct pci_pwrctrl_slot_data {

	struct pci_pwrctrl ctx;

struct slot_pwrctrl {

	struct pci_pwrctrl pwrctrl;

	struct regulator_bulk_data *supplies;

	int num_supplies;

};



static void devm_pci_pwrctrl_slot_power_off(void *data)

static void devm_slot_pwrctrl_power_off(void *data)

{

	struct pci_pwrctrl_slot_data *slot = data;

	struct slot_pwrctrl *slot = data;



	regulator_bulk_disable(slot->num_supplies, slot->supplies);

	regulator_bulk_free(slot->num_supplies, slot->supplies);

}



static int pci_pwrctrl_slot_probe(struct platform_device *pdev)

static int slot_pwrctrl_probe(struct platform_device *pdev)

{

	struct pci_pwrctrl_slot_data *slot;

	struct slot_pwrctrl *slot;

	struct device *dev = &pdev->dev;

	struct clk *clk;

	int ret;
@@ -53,7 +53,7 @@ static int pci_pwrctrl_slot_probe(struct platform_device *pdev) 
		return ret;

	}



	ret = devm_add_action_or_reset(dev, devm_pci_pwrctrl_slot_power_off,

	ret = devm_add_action_or_reset(dev, devm_slot_pwrctrl_power_off,

				       slot);

	if (ret)

		return ret;
@@ -64,31 +64,31 @@ static int pci_pwrctrl_slot_probe(struct platform_device *pdev) 
				     "Failed to enable slot clock\n");

	}



	pci_pwrctrl_init(&slot->ctx, dev);

	pci_pwrctrl_init(&slot->pwrctrl, dev);



	ret = devm_pci_pwrctrl_device_set_ready(dev, &slot->ctx);

	ret = devm_pci_pwrctrl_device_set_ready(dev, &slot->pwrctrl);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to register pwrctrl driver\n");



	return 0;

}



static const struct of_device_id pci_pwrctrl_slot_of_match[] = {

static const struct of_device_id slot_pwrctrl_of_match[] = {

	{

		.compatible = "pciclass,0604",

	},

	{ }

};

MODULE_DEVICE_TABLE(of, pci_pwrctrl_slot_of_match);

MODULE_DEVICE_TABLE(of, slot_pwrctrl_of_match);



static struct platform_driver pci_pwrctrl_slot_driver = {

static struct platform_driver slot_pwrctrl_driver = {

	.driver = {

		.name = "pci-pwrctrl-slot",

		.of_match_table = pci_pwrctrl_slot_of_match,

		.of_match_table = slot_pwrctrl_of_match,

	},

	.probe = pci_pwrctrl_slot_probe,

	.probe = slot_pwrctrl_probe,

};

module_platform_driver(pci_pwrctrl_slot_driver);

module_platform_driver(slot_pwrctrl_driver);



MODULE_AUTHOR("Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>");

MODULE_DESCRIPTION("Generic PCI Power Control driver for PCI Slots");