Commit e41c5e61 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: remove pointless inode lookup when processing extrefs during log replay 



At unlink_extrefs_not_in_log() we do an inode lookup of the directory but
we already have the directory inode accessible as a function argument, so
the lookup is redudant. Remove it and use the directory inode passed in as
an argument.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent bd9c063e

fs/btrfs/tree-log.c

+1 −13
Original line number Diff line number Diff line
@@ -1165,10 +1165,8 @@ static int unlink_extrefs_not_in_log(struct walk_control *wc, 


	while (cur_offset < item_size) {

		struct btrfs_trans_handle *trans = wc->trans;

		struct btrfs_root *root = wc->root;

		struct btrfs_root *log_root = wc->log;

		struct btrfs_inode_extref *extref;

		struct btrfs_inode *victim_parent;

		struct fscrypt_str victim_name;

		int ret;
@@ -1202,20 +1200,10 @@ static int unlink_extrefs_not_in_log(struct walk_control *wc, 
			continue;

		}



		victim_parent = btrfs_iget_logging(btrfs_ino(dir), root);

		if (IS_ERR(victim_parent)) {

			kfree(victim_name.name);

			ret = PTR_ERR(victim_parent);

			btrfs_abort_transaction(trans, ret);

			return ret;

		}



		inc_nlink(&inode->vfs_inode);

		btrfs_release_path(wc->subvol_path);



		ret = unlink_inode_for_log_replay(wc, victim_parent, inode,

						  &victim_name);

		iput(&victim_parent->vfs_inode);

		ret = unlink_inode_for_log_replay(wc, dir, inode, &victim_name);

		kfree(victim_name.name);

		if (ret)

			return ret;