Commit e43772dc authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

mm/damon/core-test: fix damon_test_ops_registration() for DAMON_VADDR unset case 

DAMON core kunit test can be executed without CONFIG_DAMON_VADDR.  In the
case, vaddr DAMON ops is not registered.  Meanwhile, ops registration
kunit test assumes the vaddr ops is registered.  Check and handle the case
by registrering fake vaddr ops inside the test code.

Link: https://lkml.kernel.org/r/20240827030336.7930-6-sj@kernel.org


Fixes: 4f540f5a ("mm/damon/core-test: add a kunit test case for ops registration")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9fcce7e7

mm/damon/core-test.h

+16 −1
Original line number Diff line number Diff line
@@ -247,8 +247,16 @@ static void damon_test_ops_registration(struct kunit *test) 
{

	struct damon_ctx *c = damon_new_ctx();

	struct damon_operations ops = {.id = DAMON_OPS_VADDR}, bak;

	bool need_cleanup = false;



	/* DAMON_OPS_VADDR is registered on subsys_initcall */

	/* DAMON_OPS_VADDR is registered only if CONFIG_DAMON_VADDR is set */

	if (!damon_is_registered_ops(DAMON_OPS_VADDR)) {

		bak.id = DAMON_OPS_VADDR;

		KUNIT_EXPECT_EQ(test, damon_register_ops(&bak), 0);

		need_cleanup = true;

	}



	/* DAMON_OPS_VADDR is ensured to be registered */

	KUNIT_EXPECT_EQ(test, damon_select_ops(c, DAMON_OPS_VADDR), 0);



	/* Double-registration is prohibited */
@@ -274,6 +282,13 @@ static void damon_test_ops_registration(struct kunit *test) 
	KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL);



	damon_destroy_ctx(c);



	if (need_cleanup) {

		mutex_lock(&damon_ops_lock);

		damon_registered_ops[DAMON_OPS_VADDR] =

			(struct damon_operations){};

		mutex_unlock(&damon_ops_lock);

	}

}



static void damon_test_set_regions(struct kunit *test)