Commit e4655196 authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Julia Lawall
Browse files

coccinelle: misc: minmax: Suppress reports for err returns 



Most of the people prefer:

return ret < 0 ? ret: 0;

than:

return min(ret, 0);

Let's tweak the cocci file to ignore those lines completely.

Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
parent 96fca68c

scripts/coccinelle/misc/minmax.cocci

+16 −16
Original line number Diff line number Diff line
@@ -50,11 +50,26 @@ func(...) 
	...>

}



// Ignore errcode returns.

@errcode@

position p;

identifier func;

expression x;

binary operator cmp = {<, <=};

@@



func(...)

{

	<...

	return ((x) cmp@p 0 ? (x) : 0);

	...>

}



@rmin depends on !patch@

identifier func;

expression x, y;

binary operator cmp = {<, <=};

position p;

position p != errcode.p;

@@



func(...)
@@ -116,21 +131,6 @@ func(...) 
	...>

}



// Don't generate patches for errcode returns.

@errcode depends on patch@

position p;

identifier func;

expression x;

binary operator cmp = {<, <=};

@@



func(...)

{

	<...

	return ((x) cmp@p 0 ? (x) : 0);

	...>

}



@pmin depends on patch@

identifier func;

expression x, y;