Commit e46f25f5 authored by Alison Schofield's avatar Alison Schofield Committed by Dave Jiang
Browse files

cxl/region: Test CXL_DECODER_F_NORMALIZED_ADDRESSING as a bitmask 



The CXL decoder flags are defined as bitmasks, not bit indices.
Using test_bit() to check them interprets the mask value as a bit
index, which is the wrong test.

For CXL_DECODER_F_NORMALIZED_ADDRESSING the test reads beyond the
flags word, making the flag sometimes appear set and blocking creation
of CXL region debugfs attributes that support poison operations.

Replace test_bit() with a bitmask check.

Found with cxl-test.

Fixes: 208f4324 ("cxl: Disable HPA/SPA translation handlers for Normalized Addressing")
Signed-off-by: default avatarAlison Schofield <alison.schofield@intel.com>
Reviewed-by: default avatarGregory Price <gourry@gourry.net>
Tested-by: default avatarGregory Price <gourry@gourry.net>
Link: https://patch.msgid.link/63fe4a6203e40e404347f1cdc7a1c55cb4959b86.1771873256.git.alison.schofield@intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 0a70b7cd

drivers/cxl/core/region.c

+1 −1
Original line number Diff line number Diff line
@@ -1105,7 +1105,7 @@ static void cxl_region_setup_flags(struct cxl_region *cxlr, 
		clear_bit(CXL_REGION_F_NEEDS_RESET, &cxlr->flags);

	}



	if (test_bit(CXL_DECODER_F_NORMALIZED_ADDRESSING, &cxld->flags))

	if (cxld->flags & CXL_DECODER_F_NORMALIZED_ADDRESSING)

		set_bit(CXL_REGION_F_NORMALIZED_ADDRESSING, &cxlr->flags);

}