Commit e493073d authored Apr 16, 2005 by akpm@osdl.org Committed by Linus Torvalds Apr 16, 2005

[PATCH] Fix acl Oops




)


From: Andreas Gruenbacher <agruen@suse.de>

ext[23]_get_acl will return an error when reading the attribute fails or
out-of-memory occurs.  Catch this case.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 81ddef77

fs/ext2/acl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int mask)
		{
		struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS);

		if (IS_ERR(acl))
		return PTR_ERR(acl);
		if (acl) {
		int error = posix_acl_permission(inode, acl, mask);
		posix_acl_release(acl);

fs/ext3/acl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -286,6 +286,8 @@ ext3_check_acl(struct inode *inode, int mask)
		{
		struct posix_acl *acl = ext3_get_acl(inode, ACL_TYPE_ACCESS);

		if (IS_ERR(acl))
		return PTR_ERR(acl);
		if (acl) {
		int error = posix_acl_permission(inode, acl, mask);
		posix_acl_release(acl);