Commit e4db80d8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu
Browse files

hwrng: virtio - Remove usage of the deprecated ida_simple_xx() API 



ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1bed8225

drivers/char/hw_random/virtio-rng.c

+3 −3
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ static int probe_common(struct virtio_device *vdev) 
	if (!vi)

		return -ENOMEM;



	vi->index = index = ida_simple_get(&rng_index_ida, 0, 0, GFP_KERNEL);

	vi->index = index = ida_alloc(&rng_index_ida, GFP_KERNEL);

	if (index < 0) {

		err = index;

		goto err_ida;
@@ -166,7 +166,7 @@ static int probe_common(struct virtio_device *vdev) 
	return 0;



err_find:

	ida_simple_remove(&rng_index_ida, index);

	ida_free(&rng_index_ida, index);

err_ida:

	kfree(vi);

	return err;
@@ -184,7 +184,7 @@ static void remove_common(struct virtio_device *vdev) 
		hwrng_unregister(&vi->hwrng);

	virtio_reset_device(vdev);

	vdev->config->del_vqs(vdev);

	ida_simple_remove(&rng_index_ida, vi->index);

	ida_free(&rng_index_ida, vi->index);

	kfree(vi);

}