Commit e5182305 authored by Sharan Kumar M's avatar Sharan Kumar M Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx 

This patch adds the HP OMEN 16 Laptop xd000xx to enable mute led.
it uses ALC245_FIXUP_HP_MUTE_LED_COEFBIT with a slight modification
setting mute_led_coef.off to 0(it was set to 4 i guess
in that function) which i referred to your previous patch disscusion
https://bugzilla.kernel.org/show_bug.cgi?id=214735

 .
i am not sure whether i can modify the current working function so i
added another version calling
ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT. and both works for me.

Tested on 6.13.4-arch1-1 to 6.14.0-arch1-1

Signed-off-by: default avatarSharan Kumar M <sharweshraajan@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20250329154105.7618-2-sharweshraajan@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2a078041

sound/pci/hda/patch_realtek.c

+22 −0
Original line number Diff line number Diff line
@@ -4743,6 +4743,22 @@ static void alc245_fixup_hp_mute_led_coefbit(struct hda_codec *codec, 
	}

}



static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,

					  const struct hda_fixup *fix,

					  int action)

{

	struct alc_spec *spec = codec->spec;



	if (action == HDA_FIXUP_ACT_PRE_PROBE) {

		spec->mute_led_polarity = 0;

		spec->mute_led_coef.idx = 0x0b;

		spec->mute_led_coef.mask = 1 << 3;

		spec->mute_led_coef.on = 1 << 3;

		spec->mute_led_coef.off = 0;

		snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);

	}

}



/* turn on/off mic-mute LED per capture hook by coef bit */

static int coef_micmute_led_set(struct led_classdev *led_cdev,

				enum led_brightness brightness)
@@ -7911,6 +7927,7 @@ enum { 
	ALC245_FIXUP_TAS2781_SPI_2,

	ALC287_FIXUP_YOGA7_14ARB7_I2C,

	ALC245_FIXUP_HP_MUTE_LED_COEFBIT,

	ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT,

	ALC245_FIXUP_HP_X360_MUTE_LEDS,

	ALC287_FIXUP_THINKPAD_I2S_SPK,

	ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD,
@@ -10164,6 +10181,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc245_fixup_hp_mute_led_coefbit,

	},

	[ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc245_fixup_hp_mute_led_v1_coefbit,

	},

	[ALC245_FIXUP_HP_X360_MUTE_LEDS] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc245_fixup_hp_mute_led_coefbit,
@@ -10658,6 +10679,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x8b97, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

	SND_PCI_QUIRK(0x103c, 0x8bb3, "HP Slim OMEN", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8bb4, "HP Slim OMEN", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8bcd, "HP Omen 16-xd0xxx", ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT),

	SND_PCI_QUIRK(0x103c, 0x8bdd, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8bde, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),

	SND_PCI_QUIRK(0x103c, 0x8bdf, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),