Commit e527adfb authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Shawn Guo
Browse files

firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels() 



If mbox_request_channel_byname() fails, the memory allocated a few lines
above still need to be freed before going to the error handling path.

Fixes: 04632698 ("firmware: imx: Save channel name for further use")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 0bb80ecc

drivers/firmware/imx/imx-dsp.c

+1 −0
Original line number Diff line number Diff line
@@ -114,6 +114,7 @@ static int imx_dsp_setup_channels(struct imx_dsp_ipc *dsp_ipc) 
		dsp_chan->idx = i % 2;

		dsp_chan->ch = mbox_request_channel_byname(cl, chan_name);

		if (IS_ERR(dsp_chan->ch)) {

			kfree(dsp_chan->name);

			ret = PTR_ERR(dsp_chan->ch);

			if (ret != -EPROBE_DEFER)

				dev_err(dev, "Failed to request mbox chan %s ret %d\n",