Commit e54b4db3 authored by Louis-Alexis Eyraud's avatar Louis-Alexis Eyraud Committed by Jakub Kicinski
Browse files

net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised 



In mtk_star_rx_poll function, on event processing completion, the
mtk_star_emac driver calls napi_complete_done but ignores its return
code and enable RX DMA interrupts inconditionally. This return code
gives the info if a device should avoid rearming its interrupts or not,
so fix this behaviour by taking it into account.

Fixes: 8c7bd5a4 ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: default avatarLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Acked-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-2-f3fde2e529d8@collabora.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6fe08660

drivers/net/ethernet/mediatek/mtk_star_emac.c

+1 −2
Original line number Diff line number Diff line
@@ -1348,8 +1348,7 @@ static int mtk_star_rx_poll(struct napi_struct *napi, int budget) 
	priv = container_of(napi, struct mtk_star_priv, rx_napi);



	work_done = mtk_star_rx(priv, budget);

	if (work_done < budget) {

		napi_complete_done(napi, work_done);

	if (work_done < budget && napi_complete_done(napi, work_done)) {

		spin_lock_irqsave(&priv->lock, flags);

		mtk_star_enable_dma_irq(priv, true, false);

		spin_unlock_irqrestore(&priv->lock, flags);