Commit e580beaf authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Jakub Kicinski
Browse files

eth: mlx4: Fix IS_ERR() vs NULL check bug in mlx4_en_create_rx_ring 



Replace NULL check with IS_ERR() check after calling page_pool_create()
since this function returns error pointers (ERR_PTR).
Using NULL check could lead to invalid pointer dereference.

Fixes: 8533b14b ("eth: mlx4: create a page pool for Rx")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20250828121858.67639-1-linmq006@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c6dd1aa2

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+3 −1
Original line number Diff line number Diff line
@@ -267,8 +267,10 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv, 
	pp.dma_dir = priv->dma_dir;



	ring->pp = page_pool_create(&pp);

	if (!ring->pp)

	if (IS_ERR(ring->pp)) {

		err = PTR_ERR(ring->pp);

		goto err_ring;

	}



	if (xdp_rxq_info_reg(&ring->xdp_rxq, priv->dev, queue_index, 0) < 0)

		goto err_pp;