Commit e588522d authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

misc: pch_phub: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-6-ba5e79fe8771@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fc58d178

drivers/misc/pch_phub.c

+4 −4
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ static int pch_phub_write_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data) 
}



static ssize_t pch_phub_bin_read(struct file *filp, struct kobject *kobj,

				 struct bin_attribute *attr, char *buf,

				 const struct bin_attribute *attr, char *buf,

				 loff_t off, size_t count)

{

	unsigned int rom_signature;
@@ -553,7 +553,7 @@ static ssize_t pch_phub_bin_read(struct file *filp, struct kobject *kobj, 
}



static ssize_t pch_phub_bin_write(struct file *filp, struct kobject *kobj,

				  struct bin_attribute *attr,

				  const struct bin_attribute *attr,

				  char *buf, loff_t off, size_t count)

{

	int err;
@@ -655,8 +655,8 @@ static const struct bin_attribute pch_bin_attr = { 
		.mode = S_IRUGO | S_IWUSR,

	},

	.size = PCH_PHUB_OROM_SIZE + 1,

	.read = pch_phub_bin_read,

	.write = pch_phub_bin_write,

	.read_new = pch_phub_bin_read,

	.write_new = pch_phub_bin_write,

};



static int pch_phub_probe(struct pci_dev *pdev,