Commit e589adf5 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jakub Kicinski
Browse files

iavf: Fix a locking bug in an error path 



If the netdev lock has been obtained, unlock it before returning.
This bug has been detected by the Clang thread-safety analyzer.

Fixes: afc66498 ("eth: iavf: extend the netdev_lock usage")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20250206175114.1974171-28-bvanassche@acm.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 06ea2c9c

drivers/net/ethernet/intel/iavf/iavf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2903,8 +2903,8 @@ static void iavf_watchdog_task(struct work_struct *work) 
	}



	mutex_unlock(&adapter->crit_lock);

	netdev_unlock(netdev);

restart_watchdog:

	netdev_unlock(netdev);

	if (adapter->state >= __IAVF_DOWN)

		queue_work(adapter->wq, &adapter->adminq_task);

	if (adapter->aq_required)