Commit e5d253c6 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: SVM: Propagate error from snp_guest_req_init() to userspace 



If snp_guest_req_init() fails, return the provided error code up the
stack to userspace, e.g. so that userspace can log that KVM_SEV_INIT2
failed, as opposed to some random operation later in VM setup failing
because SNP wasn't actually enabled for the VM.

Note, KVM itself doesn't consult the return value from __sev_guest_init(),
i.e. the fallout is purely that userspace may be confused.

Fixes: 88caf544 ("KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202410192220.MeTyHPxI-lkp@intel.com
Link: https://lore.kernel.org/r/20241031203214.1585751-1-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 2657b82a

arch/x86/kvm/svm/sev.c

+5 −2
Original line number Diff line number Diff line
@@ -450,8 +450,11 @@ static int __sev_guest_init(struct kvm *kvm, struct kvm_sev_cmd *argp, 
		goto e_free;



	/* This needs to happen after SEV/SNP firmware initialization. */

	if (vm_type == KVM_X86_SNP_VM && snp_guest_req_init(kvm))

	if (vm_type == KVM_X86_SNP_VM) {

		ret = snp_guest_req_init(kvm);

		if (ret)

			goto e_free;

	}



	INIT_LIST_HEAD(&sev->regions_list);

	INIT_LIST_HEAD(&sev->mirror_vms);