Commit e5ed2f03 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Paolo Abeni
Browse files

net: qede: use return from qede_flow_spec_validate_unused()



When calling qede_flow_spec_validate_unused() then
the return code was only used for a non-zero check,
and then -EOPNOTSUPP was returned.

qede_flow_spec_validate_unused() can currently fail with:
* -EOPNOTSUPP

This patch changes qede_flow_spec_to_rule() to use the
actual return code from qede_flow_spec_validate_unused(),
so it's no longer assumed that all errors are -EOPNOTSUPP.

Only compile tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 146817ec
Loading
Loading
Loading
Loading
+4 −3
Original line number Diff line number Diff line
@@ -1979,10 +1979,11 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
	struct ethtool_rx_flow_spec_input input = {};
	struct ethtool_rx_flow_rule *flow;
	__be16 proto;
	int err = 0;
	int err;

	if (qede_flow_spec_validate_unused(edev, fs))
		return -EOPNOTSUPP;
	err = qede_flow_spec_validate_unused(edev, fs);
	if (err)
		return err;

	switch ((fs->flow_type & ~FLOW_EXT)) {
	case TCP_V4_FLOW: